Don't use rexml for the JUnit formatter #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Sep 17, 2024
| @@ -4,7 +4,6 @@ | |||
| require "spec_utils" | |||
| require "erb_lint/cli" | |||
| require "erb_lint/cache" | |||
| require "pp" | |||
There was a problem hiding this comment.
This is needed. Somehow the load order is now different, so this now runs into fakefs/fakefs#215
| else | ||
| offenses.each do |offense| | ||
| type = offense.simple_name | ||
| message = "#{type}: #{xml_escape(offense.message)}" |
There was a problem hiding this comment.
Can we escape the whole string instead?
|
|
||
| puts %( <testcase name="#{filename}" file="#{filename}" lineno="#{offense.line_number}">) | ||
| puts %( <failure message="#{message}" type="#{type}">) | ||
| puts %( #{message} at #{filename}:#{offense.line_number}:#{offense.column}) |
There was a problem hiding this comment.
Same here, instead of separately escaping message and filename, can we escape the whole string once?
| testsuite_element.add_element(create_properties) | ||
| puts %( <properties>) | ||
| PROPERTIES.each do |key, value| | ||
| puts %( <property name="#{key}" value="#{value}"/>) |
There was a problem hiding this comment.
There's little risk but we should still be escaping all the attributes we pass IMO.
Closes Shopify#371 Follows rubocop/rubocop#13165 This leaves the output mostly the same, except that text is no longer wrapped in CDATA. Some things possibly need to be escaped now, and CDATA has different escaping needs. So, just use the same escaping everywhere
Earlopain
force-pushed
the
junit-no-rexml
branch
from
5ed086c
to
12e1659
Compare
Yeah, sure. It shouldn't matter much. I just added escaping to pretty much everything now. |
etiennebarrie
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #371
Follows rubocop/rubocop#13165
This leaves the output mostly the same, except that text is no longer wrapped in CDATA. Some things possibly need to be escaped now, and CDATA has different escaping needs. So, just use the same escaping everywhere